Use the default value for a TopologyOption if omitted #3165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems like a reasonable change in behaviour, but the scope-ui always fills in the defaults provided by |
|
Here's a screen grab of it going wrong. I click on 'Deploy', start recording, click on 'Explore'.
|
foot
approved these changes
May 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, we see unmanaged, uncontained or not-running containers in the graph until the front-end requests them to go away.
There was a shouty comment saying not to use the default, but I can't see any reason to take that stance. There is only one place where
""is a valid value, which is namespaces, and it is also the default there.To be safe, I changed the code to distinguish a lack of value from
""so you can have both.